Skip to content

Autofix RET503 and RET504#21207

Open
matsumotosan wants to merge 18 commits into
Lightning-AI:masterfrom
matsumotosan:fix-ret-rules
Open

Autofix RET503 and RET504#21207
matsumotosan wants to merge 18 commits into
Lightning-AI:masterfrom
matsumotosan:fix-ret-rules

Conversation

@matsumotosan
Copy link
Copy Markdown
Contributor

@matsumotosan matsumotosan commented Sep 12, 2025 •
edited by github-actions Bot
Loading

What does this PR do?

Autofix RET503 and RET504 rules.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21207.org.readthedocs.build/en/21207/

@github-actions github-actions Bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package package labels Sep 12, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (d046a96) to head (85d5492).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21207   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         269      269           
  Lines       23744    23719   -25     
=======================================
- Hits        20569    20556   -13     
+ Misses       3175     3163   -12

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2026 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (932b7e3) to head (16edd93).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21207   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         270      270           
  Lines       23973    23948   -25     
=======================================
- Hits        20748    20738   -10     
+ Misses       3225     3210   -15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@bhimrazy bhimrazy bhimrazy approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@lantiga lantiga Awaiting requested review from lantiga

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@matsumotosan @codecov-commenter @Borda @SkafteNicki @bhimrazy @justusschock @deependujha